Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enhanced prometheus metrics for tapd #716

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Add enhanced prometheus metrics for tapd #716

merged 2 commits into from
Dec 20, 2023

Conversation

GeorgeTsagk
Copy link
Member

Description

This PR polishes the previous prometheus framework and adds a few new collectors in order to monitor tapd instances.

@GeorgeTsagk GeorgeTsagk self-assigned this Dec 4, 2023
@GeorgeTsagk
Copy link
Member Author

Not for reviewers: Please take some time to consider what other metrics would be nice-to-have.
We already expose a variety of go runtime / GRPC related metrics, so in this PR we enhance this set with application-specific metrics to further improve our insight on a running tapd

bhandras
bhandras reviewed Dec 5, 2023
View reviewed changes
monitoring/config.go Outdated Show resolved Hide resolved
monitoring/asset_collector.go Show resolved Hide resolved
monitoring/asset_balances_collector.go Show resolved Hide resolved
@GeorgeTsagk GeorgeTsagk mentioned this pull request Dec 5, 2023
Closed
@Roasbeef Roasbeef requested a review from bhandras December 9, 2023 01:00
@GeorgeTsagk
Copy link
Member Author

Last push adds a new commit which introduces the garden_collector.go

bhandras
bhandras reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ptal at the linter error.

monitoring/garden_collector.go Outdated Show resolved Hide resolved
monitoring/garden_collector.go Show resolved Hide resolved
@GeorgeTsagk
Copy link
Member Author

@bhandras PTAL, also merged a lot of commits to a total of 2

@GeorgeTsagk GeorgeTsagk requested a review from bhandras December 12, 2023 11:51
@GeorgeTsagk GeorgeTsagk requested a review from bhandras December 14, 2023 16:38
@guggero guggero self-requested a review December 14, 2023 16:45
@dstadulis dstadulis removed the request for review from ffranr December 14, 2023 16:45
guggero
guggero approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM 🎉

monitoring/asset_balances_collector.go Outdated Show resolved Hide resolved
monitoring/asset_balances_collector.go Outdated Show resolved Hide resolved
monitoring/asset_balances_collector.go Outdated Show resolved Hide resolved
monitoring/asset_collector.go Outdated Show resolved Hide resolved
monitoring/asset_collector.go Outdated Show resolved Hide resolved
monitoring/garden_collector.go Outdated Show resolved Hide resolved
monitoring/asset_balances_collector.go Outdated Show resolved Hide resolved
monitoring/prometheus.go Outdated Show resolved Hide resolved
bhandras
bhandras approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending Oli's comments! 🎉

monitoring/asset_balances_collector.go Outdated Show resolved Hide resolved
@GeorgeTsagk GeorgeTsagk added this pull request to the merge queue Dec 20, 2023
Merged via the queue into lightninglabs:main with commit 732a90c Dec 20, 2023
14 checks passed
@Roasbeef Roasbeef mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

@bhandras bhandras bhandras approved these changes

Assignees

@GeorgeTsagk GeorgeTsagk

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgeTsagk @bhandras @guggero